Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize rawhide definitions + Improve tool used to store templates #402

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Normalize rawhide definitions + Improve tool used to store templates #402

merged 2 commits into from
Nov 25, 2020

Conversation

netoarmando
Copy link
Member

@netoarmando netoarmando commented Nov 17, 2020

  • Print and compare checksum when adding new box
Update script used to download a box to the locally hosted Vagrant
catalog to compare box's sha1sum with the one availble on the original
registry, saving time when publishing new box templates.
  • Normalize Rawhide definitions
* Update COPR repos for rawhide to don't use release numbers, build stage
was failing in recent (f34) release target.

* Add 389 COPR repo to rawhide mock definition, this way branched and
rawhide definitions look the same.

* Include disabled variables to rawhide.yml to provide an easier way to
check what's availble when building a new template.

@bhavikbhavsar
Copy link
Member

bhavikbhavsar commented Nov 24, 2020

The changes looks good, however can we add information in PR description as to what was the problem we are trying to solve?

* Update COPR repos for rawhide to don't use release numbers, build stage
was failing in recent (f34) release target.

* Add 389 COPR repo to rawhide mock definition, this way branched and
rawhide definitions look the same.

* Include disabled variables to rawhide.yml to provide an easier way to
check what's availble when building a new template.

Signed-off-by: Armando Neto <abiagion@redhat.com>
Update script used to download a box to the locally hosted Vagrant
catalog to compare box's sha1sum with the one availble on the original
registry, saving time when publishing new box templates.

Signed-off-by: Armando Neto <abiagion@redhat.com>
@netoarmando
Copy link
Member Author

The changes looks good, however can we add information in PR description as to what was the problem we are trying to solve?

Thanks for the review, I've updated the commit messages, I hope they are good enough now.

@bhavikbhavsar
Copy link
Member

The changes looks good, however can we add information in PR description as to what was the problem we are trying to solve?

Thanks for the review, I've updated the commit messages, I hope they are good enough now.

Excellent! now I understand, we can merge this changes as well. LGTM

@netoarmando netoarmando merged commit 92bc32d into freeipa:master Nov 25, 2020
@netoarmando netoarmando deleted the normalize-rawhide-definitions branch November 25, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants