Fix COPR and Python dependencies in Fedora Rawhide #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous 1.22.x version is Python 2.7 compatible. Signed-off-by: Armando Neto <abiagion@redhat.com>
When running rawhide Ansible's variable `ansible_distribution_release` is empty, it was expected to be `Rawhide`. So, instead of using that this change is adding a task to check the content of `/etc/fedora-release` file. Signed-off-by: Armando Neto <abiagion@redhat.com>
f-trivino
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
LGTM. @netoarmando thanks for the patch, I have verified the rawhide copr URL is something like:
https://download.copr.fedorainfracloud.org/results/ftrivino/krb5-ftrivino/fedora-rawhide-x86_64/
and that the "grep -qvi rawhide /etc/fedora-release" command fails when running in rawhide.
flo-renaud
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix COPR repo address in mock when in rawhide boxes
Install latest pytest-html
Issue: #467
This has been tested here: https://github.com/netoarmando/freeipa/pull/71