Improved vault-show error message

[stlaz]

Added more information to the NotFound error that may occur during
execution of vault-show. It was not clear whether the vault
really does not exist or it does not exist in a certain container.

https://fedorahosted.org/freeipa/ticket/5950

[MartinBasti]

NACK: you fixed only vault-show not other vault-* commands

NACK: I don't like the override of execute method (it should work for all vault-* commands automatically)

Is possible to override method handle_not_found of vault object? IMO which vault type is used can be determined by DN suffix (maybe it deserves a new method vault_type_from_DN()).

NACK: This is pure evil, pls keep better readability (use if-elif-else instead)

            if options.get('service'):
                container_type = 'service'
            else:
                container_type = 'shared' if options.get('shared') else 'user'

[MartinBasti]

Oh realized that is not possible to create DN inside handle_not_found, because it does not take **kwargs

Probably we can extend handle_not_found with kwargs, but this decision needs broader audience.

[stlaz]

Seems like nobody objected so far.

[MartinBasti]

Maybe *keys and **options are better names

[stlaz]

I suppose you're right, fixed it here.

[MartinBasti]

I had discussion with @jcholast and he disagrees. This weird handling of DN should stay isolated in vault code and shouldn't be spreaded across the framework. I'm starting to think that we should close ticket as won't/can't fix instead of doing that bad code even worse.

[stlaz]

WONTFIX then. There's no winning here.