Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint: enable additional checks #106

Closed
wants to merge 2 commits into from
Closed

Pylint: enable additional checks #106

wants to merge 2 commits into from

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Sep 22, 2016 •
edited

Enabling:

  • cyclic-imports
  • global-variable-not-assigned

@MartinBasti
Pylint: enable cyclic-import check
c1adc0f 
It looks that pylint stopped printing false positive errors for
cyclic-import check, thus check can be enabled.
@MartinBasti
Pylint: enable global-variable-not-assigned check
2a3c35e 
the global keyword should be used only when variable from outside is
assigned inside, otherwise it has no effect and just confuses developers
@tkrizek tkrizek self-assigned this Sep 23, 2016
@tkrizek tkrizek added the ack Pull Request approved, can be merged label Sep 23, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Sep 23, 2016
@MartinBasti
Copy link
Contributor Author

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4d7d53c9664c9e68d7c6cda1a65cae7551423df7
https://fedorahosted.org/freeipa/changeset/9b68d2a1f858854bc3cf2d6024f3fd3d79c2f696

@MartinBasti MartinBasti deleted the pylint-fixes branch October 4, 2016 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkrizek tkrizek

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@MartinBasti @tkrizek