Add fix for no-hbac-allow option in server install #116
Conversation
|
|
|
@tomaskrizek Should I remove 'no_hbac_allow' option from ipa-server-install man page then ? |
|
@Akasurde The man page is correct. However, we can no longer use the command if you simply rename the option. We need to keep this option for backwards compatibility and add a new option With I think the correct way to fix the issue is to add a new option and then make sure both the options have the same effect when used. |
| @@ -1294,7 +1294,7 @@ def idmax(self): | |||
| no_hbac_allow = Knob( | |||
| bool, False, | |||
| description="Don't install allow_all HBAC rule", | |||
| cli_name='no_hbac_allow', | |||
| cli_name='no-hbac-allow', | |||
There was a problem hiding this comment.
You should also add cli_aliases=['no_hbac_allow'] for backward compatibility.
There was a problem hiding this comment.
@jcholast Do I need to run makeapi too ?
There was a problem hiding this comment.
@Akasurde The easiest way to find out is to run it and do git diff. If there are changes in API.txt, you should have run it ;)
Just please do so that we can close this PR.
There was a problem hiding this comment.
@stlaz OK. I will do it soon.
This PR brings uniformity in option provided by no-hbac-allow and other options present in IPA server install script Fixes https://fedorahosted.org/freeipa/ticket/6357 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
changed the title
|
LGTM, thanks for the patch! |
|
@tomaskrizek @stlaz @jcholast Thanks for review comments. |
|
Fixed upstream |
Fixes: https://fedorahosted.org/freeipa/ticket/6357
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com