Tests: Duplicate declaration on variables in ID views tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ipatests/test_xmlrpc/test_idviews_plugin several variables are declared twice, while never using the first declaration. The duplicate declaration is hereby removed. https://fedorahosted.org/freeipa/ticket/6246
|
Fixed upstream |
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Nov 18, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Nov 25, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Nov 30, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Dec 7, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Dec 8, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
frasertweedale
added a commit
to frasertweedale/freeipa
that referenced
this pull request
Dec 12, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS freeipa#12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178
ghost
pushed a commit
that referenced
this pull request
Dec 12, 2016
certdb.NSSDatabase.import_files currently accumulates certificates extracted from input files as a string, which is ugly. Accumulate a list of PEMs instead, and join() them just in time for PKCS #12 creation. Part of: https://fedorahosted.org/freeipa/ticket/6178 Reviewed-By: Jan Cholasta <jcholast@redhat.com> Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ipatests/test_xmlrpc/test_idviews_plugin several variables are declared
twice, while never using the first declaration. The duplicate declaration is
hereby removed.
https://fedorahosted.org/freeipa/ticket/6246