Pylint: enable unused-variable check #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
requested changes
Sep 27, 2016
flo-renaud
reviewed
Sep 27, 2016
| @@ -368,7 +369,8 @@ def test_2_automountmap_add_duplicate(self): | |||
| """ | |||
| Test adding a duplicate direct map. | |||
| """ | |||
| res = api.Command['automountmap_add_indirect'](self.locname, self.mapname, **self.direct_kw)['result'] | |||
| api.Command['automountmap_add_indirect']( | |||
There was a problem hiding this comment.
You may want to keep the test for 'result' in the output with:
assert 'result' in api.Command...
There was a problem hiding this comment.
In this case assert is not needed because test is expecting DuplicateError to be raised. So assert is useless there.
There was a problem hiding this comment.
Agree with your comment.
|
I disagree, I really think that there should not be assert |
flo-renaud
approved these changes
Sep 27, 2016
|
Agree with you, ACK. |
stlaz
reviewed
Sep 27, 2016
| @@ -1225,7 +1226,6 @@ def __lt__(self, other): | |||
|
|
|||
| def _cmp_sequence(self, pattern, self_start, pat_len): | |||
| self_idx = self_start | |||
| self_len = len(self) | |||
| pat_idx = 0 | |||
| # and self_idx < self_len | |||
There was a problem hiding this comment.
Remove this comment as it would be even more confusing then than it is now.
| @@ -188,7 +188,7 @@ def test_remove_the_only_connection(self): | |||
| returncode, error = tasks.destroy_segment(self.master, "%s-to-%s" % replicas) | |||
| assert returncode != 0, error1 | |||
| assert error.count(text) == 1, error2 % error | |||
| newseg, err = tasks.create_segment(self.master, | |||
| _newseg, err = tasks.create_segment(self.master, | |||
| self.master, | |||
| self.replicas[1]) | |||
There was a problem hiding this comment.
You may want to add indentation here.
|
The changes seem fine except for the two small nitpicks. |
This commit removes unused variables or rename variables as "expected to be unused" by using "_" prefix. This covers only cases where fix was easy or only one unused variable was in a module
This commit removes or marks unused variables as "expected to be unused" by using '_' prefix.
Unused variables may: * make code less readable * create dead code * potentialy hide issues/errors Enabled check should prevent to leave unused variable in code Check is locally disabled for modules that fix is not clear or easy or have too many occurences of unused variables
stlaz
approved these changes
Sep 27, 2016
|
The latest changes fixed the nitpicks mentioned, ACK. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules with too many unused variables have check locally disabled