Acceptance tests #122
Acceptance tests #122
Conversation
| @@ -196,3 +197,36 @@ def test_install_master(self): | |||
|
|
|||
| def test_install_kra(self): | |||
| tasks.install_kra(self.master, first_instance=True) | |||
|
|
|||
|
|
|||
| @pytest.mark.ds_acceptance | |||
There was a problem hiding this comment.
This looks like just simple_replication test, why don't you mark it instead?
Simple replication test even tests if replication is working properly, not just installation.
I would to extend simple_replication to test both cases replication of domain, and replication of ca.
There was a problem hiding this comment.
marking TestSimpleReplication: You're right, I don't know why I persuaded myself that it does something else, I'll change that.
extending with ca: No, as was agreed before we don't want to involve CS more that necessary to minimize the risk of failing due to bug other than in DS.
There was a problem hiding this comment.
We need to test if replication between CAs is working
|
|
||
|
|
||
| @pytest.mark.cs_acceptance | ||
| class TestCSAcceptance(IntegrationTest): |
There was a problem hiding this comment.
This looks for me like just duplication of some installation tests, would be better to mark whole TestInstallWithCA_KRA_DNS1 test?
There was a problem hiding this comment.
Are you sure that that marking TestInstallWithCA_KRA_DNS1 would result in:
- installation of master with dns, ca
- installation of replica with ca, no dns
- installation of kra on the master
- instalation of kra on the second replica
as was agreed some time ago?
There was a problem hiding this comment.
test steps:
- master with ca and kra, no dns
- replica0 caless, no dns
- replica0 install ca
- replica0 install kra
- replica0 install dns
- replica1 with CA, no dns
- replica1 install kra
- replica1 install dns
- replica2 install CA + KRA # this is more or less the same as replica 1 because now kra is supported only as two step installation (maybe we can remove this test)
- replica2 install dns
There was a problem hiding this comment.
or maybe not, we had several bugs found only on third replica
|
I quite disagree with marks, please read my inline comments |
|
Please see my inline comments, I would not bother with removing DNS tests from suite because they are fast and should not affect CA/KRA |
Starting with minimal suite that will grow as necessary.