Fix log capture when running pytests_multihosts commands #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pytests_plugins/integration/config.py::Config class provides the get_logger method in order to customize the default log of the plugin. Previously, before commit 07229c8, the code was using ipa_log_manager, a custom log solution. After moving to use the default python way, the log is not configured anymore. This PR address it changing the level to DEBUG in order to capture the output of pytest_multihosts commands. As an example, when running `ipa-server-install`, you will be able to see an output like this: ``` [[...].Host.master.cmd2] Checking DNS domain ipa.test, please wait ... [[...].Host.master.cmd2] [[...].Host.master.cmd2] The log file for this installation can be found in /var/log/ipaserver-install.log [[...].Host.master.cmd2] ============================================================================== [[...].Host.master.cmd2] This program will set up the FreeIPA Server. [[...].Host.master.cmd2] [[...].Host.master.cmd2] This includes: [[...].Host.master.cmd2] * Configure a stand-alone CA (dogtag) for certificate management [[...].Host.master.cmd2] * Configure the Network Time Daemon (ntpd) [[...].Host.master.cmd2] * Create and configure an instance of Directory Server [[...].Host.master.cmd2] * Create and configure a Kerberos Key Distribution Center (KDC) ``` Fixes: https://pagure.io/freeipa/issue/7186
nicki-krizek
added
ack
Contributor
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytests_plugins/integration/config.py::Config class
provides the get_logger method in order to customize the
default log of the plugin.
Previously, before commit 07229c8,
the code was using ipa_log_manager, a custom log solution. After
moving to use the default python way, the log is not configured anymore.
This PR address it changing the level to DEBUG in order to capture
the output of pytest_multihosts commands.
As an example, when running
ipa-server-install, you will be ableto see an output like this:
Fixes: https://pagure.io/freeipa/issue/7186