Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Fix build for travis-ci #1346

Closed
wants to merge 3 commits into from

Conversation

abbra
Copy link
Contributor

@abbra abbra commented Nov 29, 2017

This PR was opened automatically because PR #1344 was pushed to master and backport to ipa-4-6 is required.

When testing KDC code in cmocka we rely on libkrb5 defaults.
libkrb5 would read /etc/krb5.conf by default and would load a KDB
module from there if it is defined for the test realm (EXAMPLE.COM).

Since EXAMPLE.COM is a common name used for test realms, make sure to
not using /etc/krb5.conf from the system. Instead, force KRB5_CONFIG to
/dev/null so that only libkrb5 compiled-in defaults are in use.

In such setup libkrb5 will attempt to load KDB driver db2 for our test
realm. db2 driver doesn't fail if its database is not available (unlike
FreeIPA's one), so it survives initialization.

As result, ipa-kdb-tests pass without unexpected breakage.
When 'make check' is run, automake produces logs for each test to be ran.
Collect all the logs from the tests.

Also prepare the template to quickly enable use of gdb with traceback
in case a test is crashing. To use it, add LOG_COMPILE definition to
the 'make' line.
If IPv6 is not enabled, cope with the possibility to get incomplete
output back from the IPA CLI.

To do so, use lambda to analyze the result rather than explicit
comparison with the expected output.
@abbra
Copy link
Contributor Author

abbra commented Nov 29, 2017

PR was ACKed automatically because this is backport of PR #1344. Wait for CI to finish before pushing. In case of questions or problems contact @abbra who is author of the original PR.

@abbra abbra added ack Pull Request approved, can be merged re-run Trigger a new run of PR-CI labels Nov 29, 2017
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Nov 29, 2017
@abbra
Copy link
Contributor Author

abbra commented Nov 29, 2017

ipa-4-6:

  • abcbb45 ipa-kdb: override krb5.conf when testing KDC code in cmocka
  • 993eb74 travis-ci: collect logs from cmocka tests
  • c380e42 test_dns_plugin: cope with missing IPv6 in Travis

@abbra abbra added the pushed Pull Request has already been pushed label Nov 29, 2017
@abbra abbra closed this Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants