Unaccessible variable self.attrs in Tracker #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apophys
suggested changes
Oct 10, 2016
| @@ -76,6 +76,7 @@ def __init__(self, default_version=None): | |||
| self.api = api | |||
| self.default_version = default_version or API_VERSION | |||
| self._dn = None | |||
| self.attrs = None | |||
There was a problem hiding this comment.
Can you point me to an instance of some method or test accessing the attributes? I think an empty dictionary would be more appropriate here.
|
NACK, comments inline. |
|
You're right, empty dict is more applicable here. I will close that one and open new with suggested fix. |
|
That's not how pull requests work. You should change the commit and force push it to the branch instead. |
|
You can check last step in this howto http://www.freeipa.org/page/Pull_request_on_Github |
In tracker, 'self.attrs' variable is created and filled in track_create method. Some objects are not created but still require access to this variable. Created 'self.attrs' variable in init https://fedorahosted.org/freeipa/ticket/6125
apophys
approved these changes
Oct 21, 2016
|
Thank you, ack. |
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tracker, 'self.attrs' variable is created and filled in track_create method.
Some objects are not created but still require access to this variable.
Created 'self.attrs' variable in init
https://fedorahosted.org/freeipa/ticket/6125