Build system cleanup #155
Closed
Build system cleanup #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
reviewed
Oct 12, 2016
| @@ -91,7 +91,7 @@ dnl --------------------------------------------------------------------------- | |||
|
|
|||
| AC_MSG_NOTICE([Checking for Python]) | |||
| have_python=no | |||
| AM_PATH_PYTHON(2.3) | |||
| AM_PATH_PYTHON(2.7) | |||
|
Works for me, Not pushing yet to give time to others to disagree |
|
Needs rebase |
It was working accidentally because krb5 libs are part of OPENLDAP_LIBS.
Use package config instead of checking headers. Package config is faster because it does not invoke compiler and guarantees proper linking flags because these are provided by package maintainer instead of hardcoded into build system. libkrad does not have package config file so we keep the old way here.
Use package config instead of checking headers. Package config is faster because it does not invoke compiler and guarantees proper linking flags because these are provided by package maintainer instead of hardcoded into build system.
Use package config instead of checking headers. Package config is faster because it does not invoke compiler and guarantees proper linking flags because these are provided by package maintainer instead of hardcoded into build system.
Mozldap is not used for some time now. We can remove all traces of it. AFAIK the complex logic for OpenLDAP detection should not be necessary and -lldap_r -llber options should suffice. Unfortunatelly OpenLDAP package does not ship package config files so we have to hardcode flags.
The Python detection logic will be improved later when we start to use top-level configure.ac to manage build completely. For now simple bump is enough.
Interestingly, the new macro AC_HEADER_STDC is alredy present.
pspacek
force-pushed
the
build-cleanup
branch
from
9e8201b
to
bf1cb89
Compare
|
I think all these fix commits are just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first step in build system refactoring effort.
This patch set contains cleanup patches for daemons/configure.ac.
After the cleanup, the file will be "promoted" to top-level configure.ac
and merged with other configure.ac files in subdirectories.
I did not touch other configure.ac files on purpose as these mostly duplicate
daemons/configure.ac and will be simply dropped later on.
From functional perspective, there should not be any visible changes.
FreeIPA should build as before, using the same horrible Makefile.