cert: add revocation reason back to cert-find output #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found one difference in output of cert-find command before and after this patch, it behaves differently only with --raw option. In output of the command without your commit there is following line: revoked: True . With your changes this line is missing. Tried using this command (the same behaviour is in API): Would it be possible to keep there also this information? |
|
It's intentional. With I should have mentioned it in the commit message though... |
In commit c718ef0 some param values were accidentally removed from cert-find output. In commit 22d5f57 `serial_number_hex` and `revoked` were added back. Add back `revocation_reason` as well. Also, do not include `revoked` with --raw, as it's a virtual attribute. https://fedorahosted.org/freeipa/ticket/6269
|
Ah, OK, then it works correctly. ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit c718ef0 some param values were
accidentally removed from cert-find output.
In commit 22d5f57
serial_number_hexandrevokedwere added back.Add back
revocation_reasonas well.https://fedorahosted.org/freeipa/ticket/6269