Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: update Patternfly and Bootstrap #158

Closed
wants to merge 1 commit into from

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Oct 12, 2016

Current versions:
PatternFly: 3.9.0
Boostrap: 3.3.7
Bootstrap-select: 1.4.3
Font-Awesome: 4.0.3

https://fedorahosted.org/freeipa/ticket/6394

@redhatrises
Copy link
Contributor

redhatrises commented Oct 12, 2016

@pvomacka should the patternfly code use the patternfly RPM rather than having the code copied here as well? See https://www.redhat.com/archives/patternfly/2014-July/msg00017.html

@pvomacka
Copy link
Author

@redhatrises Thank you for the comment and the link. I agree that it would be really nice, but unfortunately there is no PatternFly package in Fedora.

Anyway, I would be happy to do a review of a PatternFly package.

@redhatrises
Copy link
Contributor

@redhatrises Thank you for the comment and the link. I agree that it would be really nice, but unfortunately there is no PatternFly package in Fedora.

@pvomacka you're right. I should have checked. They do exist in the Patternfly Copr repos: https://copr.fedorainfracloud.org/coprs/patternfly/

Not sure if those can be used or a request needs to be made to include those RPMs into Fedora?

@pvoborni
Copy link
Member

I don't think the patternfly package can be included in Fedora as is. It internally bundles several packages, some of them already packaged (jquery, fontawesome-fonts, OpenSans-fonts).

Additionally tha package puts files on non-standard place.

Some info about Fedora packaging:

@MartinBasti
Copy link
Contributor

works for me

Current versions:
	PatternFly: 3.9.0
	Boostrap: 3.3.7
	Bootstrap-select: 1.4.3
	Font-Awesome: 4.0.3

https://fedorahosted.org/freeipa/ticket/6394
@pvomacka
Copy link
Author

I added minimized patternfly and boostrap javascript files instead of classic ones.

@MartinBasti
Copy link
Contributor

Bump for review

@pvoborni pvoborni added the ack Pull Request approved, can be merged label Jan 5, 2017
@pvoborni
Copy link
Member

pvoborni commented Jan 5, 2017

works for me

@pvoborni
Copy link
Member

pvoborni commented Jan 5, 2017

@pvoborni pvoborni added the pushed Pull Request has already been pushed label Jan 5, 2017
@pvoborni pvoborni closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants