spec file: clean up BuildRequires #159
Conversation
|
Interestingly, the CI failed with following errors: ************* Module ipatests.test_xmlrpc.test_automount_plugin ipatests/test_xmlrpc/test_automount_plugin.py:34: [E0401(import-error), ] Unable to import 'nose.tools') ************* Module ipatests.test_xmlrpc.test_hbactest_plugin ipatests/test_xmlrpc/test_hbactest_plugin.py:27: [E0401(import-error), ] Unable to import 'nose.tools') ************* Module ipatests.test_xmlrpc.test_pwpolicy_plugin ipatests/test_xmlrpc/test_pwpolicy_plugin.py:24: [E0401(import-error), ] Unable to import 'nose.tools') ************* Module ipatests.test_xmlrpc.test_external_members ipatests/test_xmlrpc/test_external_members.py:24: [E0401(import-error), ] Unable to import 'nose') ************* Module lite-server lite-server.py:36: [E0401(import-error), ] Unable to import 'paste') lite-server.py:37: [E0401(import-error), ] Unable to import 'paste.gzipper') lite-server.py:38: [E0401(import-error), ] Unable to import 'paste.urlmap') ************* Module ipa-ods-exporter daemons/dnssec/ipa-ods-exporter:29: [E0401(import-error), ] Unable to import 'systemd.daemon') daemons/dnssec/ipa-ods-exporter:30: [E0401(import-error), ] Unable to import 'systemd.journal') Weren't you to eager in pruning BuildRequires? :-) |
|
Please update BUILD.txt with how to run pylint with build, probably freeipa.org should be updated as well |
|
@pspacek, @mbasti-rh, fixed. |
In person, we were talking about some changes in the message. I would try something like this:
|
|
For some reason, after running Adding edit: This was done on minimal systems with "Development Tools" group installed. The very same .spec file works on other systems, though. |
|
On F24 you need to explicitly install python-srpm-macros due to broken package dependencies otherwise dnf/rpm is unable to expand python-specific macros in the spec and fails. |
|
Version rebased on top of current master (without PR 171) is available from https://github.com/pspacek/freeipa/tree/pr159-rebase . |
|
This pull request was (again) rebased on top of PR#171. PR#171 changes ipaplatform handling to symlinks so the issue caused by The code is again available from https://github.com/pspacek/freeipa/tree/pr159-rebase |
|
The rebased PR have passed build + all XMLRPC tests in Jenkins: The test included everything up to e33e00b |
Add missing cyrus-sasl-devel, python-cffi, python-custodia, python-dateutil, python-nose, python-paste, python-sss-murmur, python-sssdconfig and systemd-python BuildRequires. Remove unused custodia, java-headless, m4, policycoreutils, python-kdcproxy, python-rhsm, pyOpenSSL and systemd-units BuildRequires. Correct versioned BuildRequires and provide explanatory comments. https://fedorahosted.org/freeipa/ticket/6418
Lint is never executed from rpmbuild, so the BuildRequires for lint are purely informational. Include them only if %with_lint RPM macro is specified. Update .travis.yml accordingly. https://fedorahosted.org/freeipa/ticket/6418
Check for import errors with pylint to make sure new python package dependencies are not overlooked. https://fedorahosted.org/freeipa/ticket/6418
Instead of importing ipalib to get IPA version string, create setup.py from a template and have the version string automatically filled in. This makes it possible to build the ipaserver package without having to have ipalib dependencies installed. https://fedorahosted.org/freeipa/ticket/6418
Add import hook to makeapi and makeaci which makes them ignore import errors in modules in our source tree and instead print a warning. This makes it possible to build IPA without having to have most of our runtime dependencies installed. https://fedorahosted.org/freeipa/ticket/6418
The configure script checks for libcurl, but it is never actually used anywhere. https://fedorahosted.org/freeipa/ticket/6418
On pwpolicy module import, "klist -V" is run to determine if the installed krb5 version supports account lockout (>= 1.8). Remove the check, as we require a krb5 version which does support account lockout (1.12). https://fedorahosted.org/freeipa/ticket/6418
ghost
closed this
Add missing cyrus-sasl-devel, python-cffi, python-custodia, python-nose,
python-paste, python-sssdconfig and systemd-python BuildRequires.
Remove unused custodia, java-headless, m4, policycoreutils,
python-kdcproxy, python-rhsm, pyOpenSSL and systemd-units BuildRequires.
Correct versioned BuildRequires and provide explanatory comments.
spec file: do not include BuildRequires for lint by default
Lint is never executed from rpmbuild, so the BuildRequires for lint are
purely informational.
Include them only if %with_lint RPM macro is specified.
pylint: enable the import-error check
Check for import errors with pylint to make sure new python package
dependencies are not overlooked.
ipaserver: remove ipalib import from setup.py
Instead of importing ipalib to get IPA version string, create setup.py from
a template and have the version string automatically filled in.
This makes it possible to build the ipaserver package without having to
have ipalib dependencies installed.
makeapi, makeaci: do not fail on missing imports
Add import hook to makeapi and makeaci which makes them ignore import
errors in modules in our source tree and instead print a warning.
This makes it possible to build IPA without having to have most of our
runtime dependencies installed.
client: remove unused libcurl build dependency
pwpolicy: do not run klist on import
On pwpolicy module import, "klist -V" is run to determine if the installed
krb5 version supports account lockout (>= 1.8).
Remove the check, as we require a krb5 version which does support account
lockout (1.12).