Reverted the assertion for replica uninstall returncode #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mention either git commit (f7764cd) that fixed this behavior, or put the link to closed ticket (https://fedorahosted.org/freeipa/ticket/5725) that addressed this. Everything is recorded in our git history and/or tracking system, so 'apparently addressed' really has no place in our commit messages. |
|
Fair point. Fixed. Should we also update the initial (3230) issue? |
MartinBasti
changed the title
|
I think that issue reported in https://fedorahosted.org/freeipa/ticket/3230 is orthogonal to uninstaller returning 0 on error. I fail to see why we are even discussing this ticket in this context. |
|
Ticket https://fedorahosted.org/freeipa/ticket/5725 is in already closed milestone, please create a new one (I suppose you want backport to 4.4.3) |
As the issue with ipa installer always returning 0 returncode was addressed, the test needs to be made aware of this change. https://fedorahosted.org/freeipa/ticket/6401
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue with ipa installer always returning 0 returncode is apparently
addressed, the test needs to be made aware of this change.
https://fedorahosted.org/freeipa/ticket/3230