Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some GCC warnings #1626

Closed
wants to merge 2 commits into from
Closed

Silence some GCC warnings #1626

wants to merge 2 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 23, 2018

The ipadb_free() and ipadb_alloc() functions are only used with
KRB5_KDB_DAL_MAJOR_VERSION 5.

ipa_extdom_common.c:103:5: warning: enumeration value ‘NSS_STATUS_RETURN’ not handled in switch [-Wswitch]
ipa_kdb.c:639:13: warning: ‘ipadb_free’ defined but not used [-Wunused-function]
ipa_kdb.c:634:14: warning: ‘ipadb_alloc’ defined but not used [-Wunused-function]

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added the trivial label Feb 23, 2018
@tiran tiran requested a review from abbra February 23, 2018 09:07
The ipadb_free() and ipadb_alloc() functions are only used with
KRB5_KDB_DAL_MAJOR_VERSION 5.

ipa_kdb.c:639:13: warning: ‘ipadb_free’ defined but not used [-Wunused-function]
ipa_kdb.c:634:14: warning: ‘ipadb_alloc’ defined but not used [-Wunused-function]

Signed-off-by: Christian Heimes <cheimes@redhat.com>
NSS_STATUS_RETURN is an internal value but GCC doesn't know that.

ipa_extdom_common.c:103:5: warning: enumeration value ‘NSS_STATUS_RETURN’ not handled in switch [-Wswitch]

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@abbra
Copy link
Contributor

abbra commented Feb 23, 2018

LGTM.

@abbra abbra added ack Pull Request approved, can be merged and removed trivial labels Feb 23, 2018
@tiran tiran added the pushed Pull Request has already been pushed label Feb 23, 2018
@tiran
Copy link
Member Author

tiran commented Feb 23, 2018

master:

  • d749723 Silence GCC warning in ipa-kdb
  • 642712f Silence GCC warning in ipa_extdom

@tiran tiran closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants