Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust AD cleanup #164

Closed
wants to merge 3 commits into from
Closed

Conversation

mirielka
Copy link
Contributor

@mirielka mirielka commented Oct 14, 2016

Adding operations that remove test related trust information from AD machines.
Package samba-client is necessary for this operation, hence tests are skipped if the package is not installed.

Providing cleanup of trust information from AD machines for trusts tests.

https://fedorahosted.org/freeipa/ticket/6396
Providing cleanup of trust information from AD machines for legacy client tests.

https://fedorahosted.org/freeipa/ticket/6396
@martbab
Copy link
Contributor

martbab commented Oct 14, 2016

You can disable the false positive error globally by adding file_exists method as a member of transport object in pylint_plugins.py line 240

Method file_exists is reported by pylint as not being a member of transport
object, however it is used as such. Adding the method to object to avoid pylint
errors or unnecessary pylint disable.

https://fedorahosted.org/freeipa/ticket/6400
@mirielka
Copy link
Contributor Author

Thanks for suggestion, I added separate commit for this.

@martbab martbab self-assigned this Nov 14, 2016
@martbab martbab added the ack Pull Request approved, can be merged label Nov 14, 2016
@martbab martbab added the pushed Pull Request has already been pushed label Nov 14, 2016
@martbab martbab closed this Nov 14, 2016
@mirielka mirielka deleted the trust_ad_cleanup branch November 14, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants