Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Verify that cert-find show CA without --all #165

Closed
wants to merge 1 commit into from

Conversation

mirielka
Copy link
Contributor

@mirielka mirielka commented Oct 14, 2016

@tkrizek tkrizek self-assigned this Oct 14, 2016
@tkrizek
Copy link
Contributor

tkrizek commented Oct 14, 2016

The same check should be also performed for cert-show.

The patch also added CA to cert-request command, but testing it is probably not worth the effort, since it requires a CSR file.

@pvoborni
Copy link
Member

that reminds me this regression in cert-show: https://fedorahosted.org/freeipa/ticket/6022#comment:6

@mirielka mirielka force-pushed the ticket_6151 branch 2 times, most recently from 41dee6b to d704b59 Compare October 17, 2016 09:24
@mirielka
Copy link
Contributor Author

I added check for cert-show and cert-request (it was quite easy to add it to existing test). I'd prefer to add test for #6022 separately when bugfix is provided.

@pvoborni
Copy link
Member

Right, I only wanted to highlight the issue in #6022. It should be a separate patch.

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Oct 18, 2016
@MartinBasti
Copy link
Contributor

Ticket is in already closed milestone, please change ticket in the commit message.

@MartinBasti MartinBasti removed the ack Pull Request approved, can be merged label Oct 18, 2016
Verify that command cert-find, cert-show and cert-request show CA even without
--all.

https://fedorahosted.org/freeipa/ticket/6410
@mirielka
Copy link
Contributor Author

Sorry for that, I created new ticket and changed commit message.

@tkrizek
Copy link
Contributor

tkrizek commented Oct 19, 2016

Ticket/commit msg seems to be correct now.

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Oct 19, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Oct 26, 2016
@mirielka mirielka deleted the ticket_6151 branch October 27, 2016 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants