Jump to conversation
Unresolved conversations (4)
@HonzaCholasta HonzaCholasta Dec 7, 2016
Could we get rid of this copy-pasta? Maybe like this: ```python _chain_flag = Flag( 'chain', doc=_('Include certificate chain in output'), ) ... takes_options = LDAPCreate.takes_options + ( _chain_flag, ) ``` (Also note that all flags implicitly have default value of `False`.)
ipaserver/plugins/ca.py
frasertweedale
@tiran tiran Nov 17, 2016
Minor style nit-pick: The parenthesis are unnecessary.
ipaserver/install/cainstance.py
frasertweedale
@tiran tiran Nov 17, 2016
The line is ugly. Please convert extracted_certs to a list, append/extend the list and perform `'\n\.join(extracted_certs)` at the end of the function.
ipapython/certdb.py
frasertweedale
@tiran tiran Nov 17, 2016
you forgot to add `from ipaplatform.paths import paths`.
ipalib/x509.py
HonzaCholasta frasertweedale
Resolved conversations (0)