Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect sequence of method calls in tasks.py #18

Merged
merged 1 commit into from Aug 25, 2016
Merged

Fixed incorrect sequence of method calls in tasks.py #18

merged 1 commit into from Aug 25, 2016

Conversation

ofayans
Copy link
Contributor

@ofayans ofayans commented Aug 25, 2016

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Aug 25, 2016
@MartinBasti
Copy link
Contributor

NACK

[Thu Aug 25 13:31:13.597940 2016] [wsgi:error] [pid 130658] Traceback (most recent call last):
[Thu Aug 25 13:31:13.597945 2016] [wsgi:error] [pid 130658]   File "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 352, in wsgi_execute
[Thu Aug 25 13:31:13.597949 2016] [wsgi:error] [pid 130658]     result = self.Command[name](*args, **options)
[Thu Aug 25 13:31:13.597952 2016] [wsgi:error] [pid 130658]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 449, in __call__
[Thu Aug 25 13:31:13.597955 2016] [wsgi:error] [pid 130658]     return self.__do_call(*args, **options)
[Thu Aug 25 13:31:13.597959 2016] [wsgi:error] [pid 130658]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 477, in __do_call
[Thu Aug 25 13:31:13.597967 2016] [wsgi:error] [pid 130658]     ret = self.run(*args, **options)
[Thu Aug 25 13:31:13.597971 2016] [wsgi:error] [pid 130658]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 799, in run
[Thu Aug 25 13:31:13.597974 2016] [wsgi:error] [pid 130658]     return self.execute(*args, **options)
[Thu Aug 25 13:31:13.597978 2016] [wsgi:error] [pid 130658]   File "/usr/lib/python2.7/site-packages/ipaserver/plugins/cert.py", line 629, in execute
[Thu Aug 25 13:31:13.597981 2016] [wsgi:error] [pid 130658]     result['cacn'] = ca_obj['cacn'][0]
[Thu Aug 25 13:31:13.597984 2016] [wsgi:error] [pid 130658] KeyError: 'cacn'

@MartinBasti
Copy link
Contributor

Please update tests

@ofayans
Copy link
Contributor Author

ofayans commented Aug 25, 2016

@mbasti-rh, are these things related?

@MartinBasti
Copy link
Contributor

Sorry I commented wrong PR :D

@MartinBasti
Copy link
Contributor

This is still ACK

@ofayans ofayans merged commit 5f12a04 into freeipa:master Aug 25, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Aug 25, 2016
@MartinBasti
Copy link
Contributor

@MartinBasti
Copy link
Contributor

@ofayans This is just mirror repo of fedorahosted , we cannot merge commits here, it has no effect.

@ofayans
Copy link
Contributor Author

ofayans commented Aug 25, 2016

@mbasti-rh oh, I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants