Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __name__ == __main__ guards to setup.pys #183

Closed
wants to merge 1 commit into from
Closed

Add __name__ == __main__ guards to setup.pys #183

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 24, 2016 •
edited by MartinBasti

Signed-off-by: Christian Heimes cheimes@redhat.com

@mirielka
Copy link
Contributor

Thanks, this fixes setup.py related failure in intree tests.

@pspacek
Copy link
Contributor

pspacek commented Oct 24, 2016

@tiran PEP8 errors need to be fixed first:

./ipaclient/setup.py:28:80: E501 line too long (80 > 79 characters)
./ipalib/setup.py:28:80: E501 line too long (80 > 79 characters)
./ipaplatform/setup.py:28:80: E501 line too long (80 > 79 characters)
./ipaserver/setup.py:30:80: E501 line too long (80 > 79 characters)
./ipatests/setup.py:29:80: E501 line too long (80 > 79 characters)

Other than that, functional ACK.

@tiran
Add __name__ == __main__ guards to setup.pys
07c46dd 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Oct 25, 2016

@pspacek Fixed

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Oct 25, 2016
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/91920e7cb48cbf143ae281c9c073df14b2c2dddf

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Oct 25, 2016
@tiran tiran deleted the setup_main_guard branch October 26, 2016 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@tiran @mirielka @pspacek @MartinBasti