Minor install script fixes

[simo5]

• Use the correct unicode string for an error message, otherwise an
  exception will generate another exception about incorrect type,
  masking the original error.
• Make sure to pass down the debug flag to ipa-client-install when
  the server install is run in debug mode

[abbra]

ACK from my side if you would split the commit into two small ones, please.

Note that CI integration is currently broken so travis says your commits failed the checks.

[abbra]

ACK.

[MartinBasti]

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/2f567f0e8eb53306c5a3ecc04ac93e375b9c07d1
https://fedorahosted.org/freeipa/changeset/d650c54fe4e327f95ffcb834418a5b6af59b212c

[pvoborni]

The debug patch breaks test installation on RHEL. Following exception is printed only if install.py is adjusted to print exception on line

ipa         : ERROR    debug
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ipaserver/install/server/install.py", line 899, in install
    if options.debug:
  File "/usr/lib/python2.7/site-packages/ipapython/install/core.py", line 550, in __getattr__
    raise AttributeError(name)
AttributeError: debug

I.e. there is no Knob debug nor verbose unless it is somehow copied. I don't know why it doesn't break install on Fedora but imho the patch cannot work.

This might also be the "there is no ipa-client-install.log" issue. Because it fails just before calling ipa-client-install.

[martbab]

Note that the installer class has no access to debug options. These are only used in the containing ConfigureTool class to set up loggers (see https://git.fedorahosted.org/cgit/freeipa.git/tree/ipapython/install/cli.py#n267) and are not passed to the Configurable object.

We may need to revert commit #2 to unblock installation of FreeIPA server. The proper fix shall be implemented as a part of installer refactoring effort.

[abbra]

I'm fine with that (revert --debug commit). Either alternative (make Configurable be aware of the debug or do a refactoring of an installer) is roughly going into the same direction. I certainly see a reason to have Configurable gain knowledge about --debug option to allow it to configure specific services in debug mode which would go beyond just setting up loggers in the installer itself.

[martbab]

Reverted the Fix install scripts debugging commit.

master:

• dc87300 Revert "Fix install scripts debugging"