Register entry points of Custodia plugins #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
custodia_plugins
branch
from
93b052a
to
2968eea
Compare
tiran
force-pushed
the
custodia_plugins
branch
from
2968eea
to
0677a09
Compare
|
Just curious, why is the store class called |
|
@simo5 wrote the code. He should know why he did not follow PEP8 naming conventions for the class. |
|
Forgot the reasons, I was probably not thinking about PEP8 back then. |
With setuptools in place FreeIPA is able to register its Custodia plugins. Custodia 0.1 ignores the plugins directives. Custodia 0.2 uses the entry points to discover plugins. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
custodia_plugins
branch
from
0677a09
to
3dd1873
Compare
|
I renamed the class and plugin but kept an alias for the old name. |
|
LGTM but we will need upstream ticket for this to triage. |
|
Rebased, ticket added to commit message, pushed Fixed upstream |
MartinBasti
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With setuptools in place FreeIPA is able to register its Custodia
plugins. Custodia 0.1 ignores the plugins directives. Custodia 0.2 uses
the entry points to discover plugins.
https://fedorahosted.org/freeipa/ticket/6492
Signed-off-by: Christian Heimes cheimes@redhat.com