Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipactl: Correction of named to named-pkcs11 #1883

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@amitkumar50
Copy link
Contributor

amitkumar50 commented Apr 30, 2018

Whenever ipactl status is run it returned:
Directory Service: RUNNING
krb5kdc Service: RUNNING
kadmin Service: RUNNING
named Service: RUNNING
...

This PR changes ipactl o/p to:
Directory Service: RUNNING
krb5kdc Service: RUNNING
kadmin Service: RUNNING
named-pkcs11 Service: RUNNING

Resolves: https://pagure.io/freeipa/issue/7446

ipactl: Correction of named to named-pkcs11
Whenever ipactl status is run it returned:
Directory Service: RUNNING
krb5kdc Service: RUNNING
kadmin Service: RUNNING
named Service: RUNNING
...

This PR changes ipactl o/p to:
Directory Service: RUNNING
krb5kdc Service: RUNNING
kadmin Service: RUNNING
named-pkcs11 Service: RUNNING

Resolves: https://pagure.io/freeipa/issue/7446
@tiran

This comment has been minimized.

Copy link
Member

tiran commented Apr 30, 2018

Thanks for the PR. I have contacted Timo and asked him if the PR is correct for Debian/Ubuntu, too.

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Apr 30, 2018

@tiran Thanks. I would wait.

@tiran
Copy link
Member

tiran left a comment

The current approach doesn't work on Debian / Ubuntu. You need to to take all service names from the platform module somehow...

@strikerttd

This comment has been minimized.

Copy link

strikerttd commented May 30, 2018

This is a good starting point to trying to fix the issue, but imo, the fix needs to be made to ipactl and how it reads the actual names of the services that are starting (except for "Directory Service", because that seems to have it's own block of code).

@rcritten

This comment has been minimized.

Copy link
Contributor

rcritten commented Jul 2, 2018

If you want to print the actual service name you have to display svchandle.systemd_name (perhaps minus the .service bit).

It's been 2 months since this PR has been updated. It is on the block for closing.

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Jul 18, 2018

@rcritten Apologies for delay, give me a week time, I will update this I was over occupied.

@flo-renaud

This comment has been minimized.

Copy link
Contributor

flo-renaud commented Feb 21, 2019

Hi @amitkumar50 @rcritten
Issue 7446 has been closed as won't fix, can we close this PR?

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Feb 21, 2019

@flo-renaud

This comment has been minimized.

Copy link
Contributor

flo-renaud commented Feb 21, 2019

@amitkumar50
Thanks for your quick answer. Closing as agreed.

@flo-renaud flo-renaud closed this Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.