Create relative symbol links #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of absolute symbolic links to /usr/bin/COMMAND the RPM spec now creates relative symbolic links. Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
I think you should add the reasoning for switching the link type to the commit message and if this is related to some higher-level ticket that should be included as well. |
|
I ran into some strange issues while I was working on PR #188. The symlinks were both dangling symlinks and pointed to a directory that my user could not write to. Eventually I found the real culprit. I still think that relative symlinks are better. Python generally uses relative links for its aliases. |
|
As I said several times already, all the SPEC file logic is going away. I'm going to reject this as we do not need to change code which is going away and force everybody to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of absolute symbolic links to /usr/bin/COMMAND the RPM spec now
creates relative symbolic links.
Signed-off-by: Christian Heimes cheimes@redhat.com