server-del: fix incorrect check for one IPA master #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
reviewed
Oct 26, 2016
| @@ -473,7 +473,7 @@ def handler(msg, ignore_last_of_role): | |||
| ipa_masters = ipa_config['ipa_master_server'] | |||
|
|
|||
| # skip these checks if the last master is being removed | |||
| if ipa_masters == [hostname]: | |||
| if list(ipa_masters) == [hostname]: | |||
There was a problem hiding this comment.
Could be there just check if len(ipa_masters) > 1 : or is there any reason why you need to compare list?
|
LGTM, but I wrote possible improvement inline, please check. |
martbab
force-pushed
the
server-del-fix
branch
from
52b8dec
to
2670744
Compare
MartinBasti
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the check more robust against returned container types for multivalued
attributes (lists vs. tuples).
https://fedorahosted.org/freeipa/ticket/6417