Making nigthly test definition editable by FreeIPA contributors #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the test definition of nightly tests will be on freeipa repo. The definition that's used on every PR (previously as .freeipa-pr-ci.yaml) is in ipatests/prci_definitions/gating and the .freeipa-pr-ci.yaml file is just a symlink to the real file. In the same dir there is also nightly_master and nightly_rawhide, both to be used in nightly tests. This PR is the result of discussion on freeipa-devel mailing list [1]. [1] https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/4VAWJ4SFKKBFFICDLQCTXJWRRQHIYJLL/
Isn't it the other way around? freeipa/freeipa-pr-ci#201 changes the way how nightlies are created and depend on the definitions delivered in this PR. Gating will work regardless of freeipa/freeipa-pr-ci#201, won't' it? Edit: ah, I see. PR-CI cannot handle the symlink. It would be probably more clear to split freeipa-pr-ci#201 into two commits. One which adds support for the symlinks and other which improves opening of the nightly prs. |
freeipa-pr-ci
added
the
needs rebase
|
@flo-renaud @Rezney Can you take care of this PR when it is convenient to you? |
|
Superseded by PR #2139 |
tiran
added
rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the test definition of nightly tests will be on freeipa repo. The the definition that's used on every PR (previously as .freeipa-pr-ci.yaml) is in ipatests/prci_definitions/gating and the .freeipa-pr-ci.yaml file
is just a symlink to the real file.
In the same dir there is also nightly_master and nightly_rawhide, both to be used in nightly tests.
This PR is the result of the discussion on freeipa-devel mailing list [1].
[1] https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/4VAWJ4SFKKBFFICDLQCTXJWRRQHIYJLL/
PS: This PR depends on this PR in freeipa-pr-ci