Make setup.py files PyPI compatible #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
setup_pypi_compatible
branch
from
d97dc1c
to
5f36daa
Compare
tiran
force-pushed
the
setup_pypi_compatible
branch
2 times, most recently
from
dd20cef
to
b67be50
Compare
MartinBasti
suggested changes
Nov 14, 2016
| common_args = dict( | ||
| version="@VERSION@", | ||
| license="GPL", | ||
| license="GPLv3+", |
There was a problem hiding this comment.
Shouldn't be this GPLv3 only?
| @@ -1,5 +1,4 @@ | |||
| #!/usr/bin/python2 | |||
| # Copyright (C) 2014 Red Hat | |||
| # Copyright (C) 2016 Red Hat | |||
There was a problem hiding this comment.
Shouldn't be this in format 2014-2016?
There was a problem hiding this comment.
The file was created 2016. I forgot to correct the year when I copied over the license header.
| "Operating System :: Unix", | ||
| "Topic :: Internet :: Name Service (DNS)", | ||
| ("Topic :: System :: Systems Administration :: " | ||
| "Authentication/Directory :: LDAP"), |
There was a problem hiding this comment.
Maybe additional topic can be added as well:
- (maybe rather not include this one) Topic :: System :: Systems Administration :: Authentication/Directory :: NIS
- Topic :: Security
- Topic :: Internet :: WWW/HTTP :: WSGI :: Application
There was a problem hiding this comment.
None of the PyPI packages will contain a WSGI application. The WSGI is in ipaserver but we are not going to release the server on PyPI yet.
|
I have some inline questions |
Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
setup_pypi_compatible
branch
from
b67be50
to
814f1f0
Compare
MartinBasti
approved these changes
Nov 14, 2016
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct classifiers and license
https://fedorahosted.org/freeipa/ticket/6484
Signed-off-by: Christian Heimes cheimes@redhat.com