Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forgotten print from DN.__str__ implementation #2

Closed
wants to merge 1 commit into from
Closed

Remove forgotten print from DN.__str__ implementation #2

wants to merge 1 commit into from

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Aug 19, 2016 •
edited

These debug prints were forgotten there and should be removed, because
str(DN) is often operation and we may save time with handling exceptions
and printing unwanted debug

@MartinBasti
Remove forgotten print from DN.__str__ implementation
41459af 
These debug prints were forgotten there and should be removed, because
str(DN) is often operation and we may save time with handling exceptions
and printing unwanted debug
@ghost
Copy link

ghost commented Aug 19, 2016

Makes sence.

@ghost
Copy link

ghost commented Aug 19, 2016

Makes sence.

@ghost
Copy link

ghost commented Aug 19, 2016

Makes sense.

@ghost ghost added the ack Pull Request approved, can be merged label Aug 19, 2016
@MartinBasti
Copy link
Contributor Author

m a s t e r :

8
6
e
1
5
6
c
3
c
5
f
3
3
1
e
3
f
1
6
9
b
9
4
1
b
e
2
d
9
f
7
2
e
7
c
8
f
0
0
0

R
e
m
o
v
e

f
o
r
g
o
t
t
e
n

p
r
i
n
t

f
r
o
m

D
N
.
_
_
s
t
r
_
_

i
m
p
l
e
m
e
n
t
a
t
i
o
n

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Aug 19, 2016
@MartinBasti
Copy link
Contributor Author

Sorry testing phase of tools :)

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/86e156c3c5f331e3f169b941be2d9f72e7c8f000

@MartinBasti MartinBasti deleted the remove-forgotten-print branch August 19, 2016 12:00
@martbab martbab mentioned this pull request Oct 26, 2016
Closed
@rcritten rcritten mentioned this pull request Nov 7, 2017
Closed
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 16, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
c277034 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd for
performance enhancement ssh fro ipa client was failing

Test Procedure:
1. setup a master and a client
2. add ldap_deref_threshold=0 to sssd.conf
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 17, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
8df5c9d 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 17, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
c0cf72b 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 17, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
eff6e5f 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd for
performance enhancement ssh fro ipa client was failing

Test Procedure:
1. setup a master and a client
2. add ldap_deref_threshold=0 to sssd.conf
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 18, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
cf07461 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd for
performance enhancement ssh fro ipa client was failing

Test Procedure:
1. setup a master and a client
2. add ldap_deref_threshold=0 to sssd.conf
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 18, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
f20f581 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd for
performance enhancement ssh fro ipa client was failing

Test Procedure:
1. setup a master and a client
2. add ldap_deref_threshold=0 to sssd.conf
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Patch freeipa#6
Replaced `rpm -qa sssd` call to `sssd --version`
Added kinit <username> call

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 18, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
65ec6f9 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd for
performance enhancement ssh fro ipa client was failing

Test Procedure:
1. setup a master and a client
2. add ldap_deref_threshold=0 to sssd.conf
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Patch freeipa#6
Replaced `rpm -qa sssd` call to `sssd --version`
Added kinit <username> call

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 19, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
0c8f43d 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Patch freeipa#3
Fixed review comments

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
6e86737 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Patch freeipa#3
Fixed review comments

Patch freeipa#4
Removed hard coded realm
Other minor changes

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
5b3c4b4 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Patch freeipa#3
Fixed review comments

Patch freeipa#4
Removed hard coded realm
Other minor changes
Fixed import error

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
dfa3cf7 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd on master for
performance enhancement ssh from ipa client was failing

Test Procedure:
1. setup a master
2. add ldap_deref_threshold=0 to sssd.conf on master
3. add an ipa user
4. ssh from client to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Patch freeipa#6
Replaced `rpm -qa sssd` call to `sssd --version`
Added kinit <username> call

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: Test to check whether ssh from ipa client to ipa master
f876c74 
is successful after adding ldap_deref_threshold=0 in sssd.conf

Problem: After adding ldap_deref_threshold=0 setting for sssd on master for
performance enhancement ssh from ipa client was failing

Test Procedure:
1. setup a master
2. add ldap_deref_threshold=0 to sssd.conf on master
3. add an ipa user
4. ssh from controller to master using the user created in step 3

related ticket: https://pagure.io/SSSD/sssd/issue/3979

Removed test_client.py since this test can has added to test_commands.py.
SSH after adding performance parameter is tested from controller
machine instead of a client machine.

Patch freeipa#2
Fixed missing import

Patch freeipa#3
Added test cleanup post test

Patch freeipa#4
Used modify_sssd_conf instead of parsing lines

Patch freeipa#5
Added pytest.xfail based on the sssd package version

Patch freeipa#6
Replaced `rpm -qa sssd` call to `sssd --version`
Added kinit <username> call

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
16be3c5 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Patch freeipa#3
Fixed review comments

Patch freeipa#4
Removed hard coded realm
Other minor changes
Fixed import error

Patch freeipa#5
added test to nightly yamls

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Jul 24, 2019
@ssidhaye
Test: To check ipa replica-manage del <FQDN> does not fail
4c3dddf 
Problem:
If a replica installation fails before all the services have been enabled then
it could leave things in a bad state.

ipa-replica-manage del <replica> --cleanup --force
invalid 'PKINIT enabled server': all masters must have IPA master role enabled

Test Steps:
1. Setup server
2. Setup replica
3. modify the replica entry on Master:
   ldapmodify -D cn="Directory Manager"-w <passwd>
   dn: cn=KDC,cn=<replicaFQDN>,cn=masters,cn=ipa,cn=etc,<baseDN>
   changetype: modify
   replace: ipaconfigstring
   ipaconfigstring: pkinitEnabled
   ipaconfigstring: configuredService
4. On master,
   run ipa-replica-manage del <replicaFQDN> --cleanup --force

Related Ticket: https://pagure.io/freeipa/issue/7929

Patch freeipa#2
fixed linting errors

Patch freeipa#3
Fixed review comments

Patch freeipa#4
Removed hard coded realm
Other minor changes
Fixed import error

Patch freeipa#5
added test to nightly yamls

Patch freeipa#6
removed test added to fedora 28 nightly as it is not needed

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
tiran referenced this pull request in tiran/freeipa Mar 18, 2020
@frasertweedale
Merge pull request #2 from tscherf/master
a2dfe09 
Added vagrant-libvirt-doc rpm and polkit rule
@rcritten rcritten mentioned this pull request Feb 15, 2021
Closed
@wladich wladich mentioned this pull request May 6, 2021
Closed
@fcami fcami mentioned this pull request Jul 22, 2021
Closed
abbra pushed a commit that referenced this pull request Jul 23, 2021
@fcami
Azure: temporarily disable problematic tests, #2
baed2e6 
test_cert and test_SubCAkeyReplication are randomly failing.
The suspect for test_SubCAkeyReplication is an nss bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1985061

The reason for test_cert failures was not identified, the only
relevant line in the log contains:
2021-07-22T17:37:21.0873339Z tests: cert, result: 1, time: 30:08.98
2021-07-22T17:37:21.0874172Z Command exited with non-zero status 1

Disable these tests in gating until the NSS bug is fixed and
the related build is available in Fedora.

Related: https://pagure.io/freeipa/issue/8864
Signed-off-by: François Cami <fcami@redhat.com>
Reviewed-By: Michal Polovka <mpolovka@redhat.com>
Reviewed-By: Stanislav Levin <slev@altlinux.org>
abbra pushed a commit that referenced this pull request Jul 23, 2021
@fcami @rcritten
Azure: temporarily disable problematic tests, #2
18ccaea 
test_cert and test_SubCAkeyReplication are randomly failing.
The suspect for test_SubCAkeyReplication is an nss bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1985061

The reason for test_cert failures was not identified, the only
relevant line in the log contains:
2021-07-22T17:37:21.0873339Z tests: cert, result: 1, time: 30:08.98
2021-07-22T17:37:21.0874172Z Command exited with non-zero status 1

Disable these tests in gating until the NSS bug is fixed and
the related build is available in Fedora.

Related: https://pagure.io/freeipa/issue/8864
Signed-off-by: François Cami <fcami@redhat.com>
Reviewed-By: Michal Polovka <mpolovka@redhat.com>
Reviewed-By: Stanislav Levin <slev@altlinux.org>
Reviewed-By: Michal Polovka <mpolovka@redhat.com>
Reviewed-By: Stanislav Levin <slev@altlinux.org>
@rcritten rcritten mentioned this pull request Jul 23, 2021
Closed
@fcami fcami mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
1 participant
@MartinBasti