Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 29 renamed fedora-domainname.service #2014

Closed
wants to merge 1 commit into from

Conversation

@tiran
Copy link
Member

tiran commented Jun 11, 2018

In Fedora 29, the fedora-domainname.service has been renamed to
nis-domainname.service like on RHEL. The ipaplatform service module for
Fedora now only renames the service, when it detects the presence of
fedora-domainname.service.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1588192
Fixes: https://pagure.io/freeipa/issue/7582
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added the re-run label Jun 11, 2018
@freeipa-pr-ci2 freeipa-pr-ci2 removed the re-run label Jun 11, 2018
@tiran tiran added the re-run label Jun 11, 2018
@freeipa-pr-ci2 freeipa-pr-ci2 removed the re-run label Jun 11, 2018
@tiran tiran added the re-run label Jun 11, 2018
@freeipa-pr-ci2 freeipa-pr-ci2 removed the re-run label Jun 11, 2018
@tiran tiran force-pushed the tiran:issue7582_domainname branch 2 times, most recently from 8616c97 to 5f8f608 Jun 11, 2018
@tiran tiran added the needs review label Jun 11, 2018
@tiran tiran requested a review from rcritten Jun 11, 2018
@tiran

This comment has been minimized.

Copy link
Member Author

tiran commented Jun 11, 2018

@rcritten First I looked into adding a version check for F29. This attempt would have required me to refactor some code in ipaplatform. It was far simpler to just check for the presence of a file.

@rcritten

This comment has been minimized.

Copy link
Contributor

rcritten commented Jun 11, 2018

I have a change in my tree that I was going to just push as a patch for rawhide to just flip the name from fedora-domainname to nis-domainname while we work on it upstream. I may just hold off given this PR.

# Service that sets domainname on Fedora is called fedora-domainname.service
fedora_system_units['domainname'] = 'fedora-domainname.service'
# Fedora 28 and earlier have fedora-domainname.service. Starting from
# Fedora 29, the service is called nis-domainname.service like on RHEL.

This comment has been minimized.

Copy link
@rcritten

rcritten Jun 13, 2018

Contributor

The service is named rhel-domainname.service in RHEL. Just the comment is wrong.

@rcritten

This comment has been minimized.

Copy link
Contributor

rcritten commented Jun 13, 2018

Other than the comment this looks ok.

@tiran tiran force-pushed the tiran:issue7582_domainname branch from 5f8f608 to 872fcd2 Jun 14, 2018
In Fedora 29, the fedora-domainname.service has been renamed to
nis-domainname.service like on RHEL. The ipaplatform service module for
Fedora now only renames the service, when it detects the presence of
fedora-domainname.service.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1588192
Fixes: https://pagure.io/freeipa/issue/7582
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran force-pushed the tiran:issue7582_domainname branch from 872fcd2 to e6ece94 Jun 14, 2018
@tiran

This comment has been minimized.

Copy link
Member Author

tiran commented Jun 14, 2018

@rcritten I have updated the PR and left an explanation on the bug tracker:

  • The generic redhat service definition (parent of rhel and fedora platform definitions) now defines nis-domainname.service as default name for the domain name service.
  • The fedora service definition overrides the name as fedora-domainname.service if and only if it detects the presence of the file /usr/lib/systemd/system/fedora-domainname.service. The check will be removed when we drop support for F28.
@rcritten rcritten added ack and removed needs review labels Jun 14, 2018
@tiran

This comment has been minimized.

Copy link
Member Author

tiran commented Jun 15, 2018

master:

  • 907e164 Fedora 29 renamed fedora-domainname.service
@tiran tiran added the pushed label Jun 15, 2018
@tiran tiran closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.