Properly handle multiple cookies in rpcclient #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the end of server install many times and it is also printed by each ipa command |
simo5
force-pushed
the
rpcclient_cookies
branch
from
2433c2b
to
0c6581b
Compare
|
This new patch should fix it. |
|
could you please fix PEP8? |
|
Yes, getting there, be patient, I discovered other stuff as I fixed pylint per single patch :) |
|
Sorry I thought this PR was the priv sep one, I have fixes for this, pushing in a moment. |
simo5
force-pushed
the
rpcclient_cookies
branch
from
0c6581b
to
5fe6cac
Compare
Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
simo5
force-pushed
the
rpcclient_cookies
branch
from
5fe6cac
to
8bb4abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code does not give a list of cookies, but a concatenated string separated by a comma. This is a format the Cookie class does not understand. msg.getheaders returns the wanted format.