Tests: Stage User Tracker implementation #210
Conversation
gkaihorodova
force-pushed
the
fix-for-6448
branch
from
bef74b7
to
51c51d3
Compare
|
Review notes: same as in #181 |
gkaihorodova
force-pushed
the
fix-for-6448
branch
from
51c51d3
to
1a9ff85
Compare
|
Bump for review. |
gkaihorodova
force-pushed
the
fix-for-6448
branch
from
f82f208
to
e6c30dd
Compare
|
Can we get this PR rebased against current master to see whether Travis CI is okay? The current checks are polluted by regression that should be fixed. |
| stageduser_min.ensure_missing() | ||
| command = stageduser_min.make_create_command() | ||
| command() | ||
|
|
There was a problem hiding this comment.
Please fix the indentation here.
There was a problem hiding this comment.
Yes, sure. Sorry for that.
| if not (isinstance(givenname, six.string_types) and givenname): | ||
| raise ValueError("Invalid first name provided: %r" % givenname) | ||
| if not (isinstance(sn, six.string_types) and sn): | ||
| raise ValueError("Invalid second name provided: %r" % sn) |
There was a problem hiding this comment.
Please use str.format() instead in new code.
There was a problem hiding this comment.
ok, will apply same for #181 as well
|
I just wanted to remove the ACK till @martbab's comment is worked in so nobody pushes it but I found some minor issues that I would like to see fixed in the rebase as well. |
gkaihorodova
force-pushed
the
fix-for-6448
branch
2 times, most recently
from
941b477
to
cab565d
Compare
|
Needs rebase |
|
@gkaihorodova the PR cannot be pushed in current form because the first commit 298e1a1 is already pushed to master. So to rebase it correctly please do the following: Pull the changes from the remote repo (or any other label you have for it) into your local master branch: $ git checkout master; git pullThen do the rebase against the refreshed master branch. The first commit should now disappear as git should detect that it is already there. If not, then abort the current rebase, re-start it in interactive mode (git rebase -i master) and remove the first commit manually (just remove the first line). Then force-push the changes into your fork: $ git push -f origin fix-for-6448 |
Fix provide possibility of creation stage user with minimal values, with uid not specified and check for non-empty unicode string for attributes requested in init method https://fedorahosted.org/freeipa/ticket/6448
Test to create stage user with minimal values, where uid is not specified https://fedorahosted.org/freeipa/ticket/6448
gkaihorodova
force-pushed
the
fix-for-6448
branch
from
cab565d
to
e3b0ab2
Compare
Fix provide possibility of creation stage user with minimal values,
with uid not specified. Implementation is the same as for User Tracker.
https://fedorahosted.org/freeipa/ticket/6448