IPA Allows Password Reuse with History value defined when admin reset… #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martbab
reviewed
Nov 2, 2016
|
|
||
| /* let set the entry password property according to its | ||
| * entry password policy | ||
| */ |
There was a problem hiding this comment.
I guess the missed break statement is deliberate here. If yes it would be nice to have a comment clearly stating that the fallthrough is intentional.
There was a problem hiding this comment.
Hello, thanks for reviewing.
You are right the removal of the break is intentional in order to retrieve the user password policy (ipapwd_getPolicy) like this was done in case of password update by 'directory manager'.
I agree the fix should clearly state that fallthrough is intentional. Will change the fix.
|
Please address the comment in code. |
…s the password. When admin reset a user password, history of user passwords is preserved according to its policy. https://fedorahosted.org/freeipa/ticket/6402
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s the password.
When admin reset a user password, history of user passwords is
preserved according to its policy.
https://fedorahosted.org/freeipa/ticket/6402