libexec scripts: ldap conn management #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
reviewed
Nov 9, 2016
| @@ -507,6 +508,8 @@ def main(): | |||
| certs.renewal_lock.release() | |||
| shutil.rmtree(tmpdir) | |||
|
|
|||
| api.Backend.ldap2.disconnect() | |||
There was a problem hiding this comment.
You may want to move the disconnect() call in the finally block to make sure it gets executed
| @@ -200,6 +201,8 @@ def _main(): | |||
| syslog.syslog( | |||
| syslog.LOG_NOTICE, "Started %s" % dogtag_service.service_name) | |||
|
|
|||
| api.Backend.ldap2.disconnect() | |||
There was a problem hiding this comment.
nitpick: disconnect() may not always be called
| @@ -75,6 +76,7 @@ def _main(): | |||
| else: | |||
| syslog.syslog(syslog.LOG_NOTICE, "Restarted httpd") | |||
|
|
|||
| api.Backend.ldap2.disconnect() | |||
There was a problem hiding this comment.
Nitpick: disconnect() may not always be executed
Certificate renewal scripts require connection to LDAP. Properly handle connects and disconnects from LDAP. https://fedorahosted.org/freeipa/ticket/6461
tkrizek
force-pushed
the
refactoring-ldap3
branch
from
ab992c7
to
8f4e1c5
Compare
|
Thanks for the update. Works for me. |
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate renewal scripts require connection to LDAP. Properly
handle connects and disconnects from LDAP.
https://fedorahosted.org/freeipa/ticket/6461