Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for certs in idoverrides #224

Closed
wants to merge 3 commits into from
Closed

Integration tests for certs in idoverrides #224

wants to merge 3 commits into from

Conversation

ofayans
Copy link
Contributor

@ofayans ofayans commented Nov 10, 2016

@mirielka
Copy link
Contributor

Functionally OK.
Please extend commit message for the first commit and add links to tickets if applicable. Also ticket https://fedorahosted.org/freeipa/ticket/6146 is in closed milestone, please request update to open milestone.
I did not do code review yet, will provide next week.

@ofayans
Copy link
Contributor Author

ofayans commented Nov 14, 2016

@mirielka done, thank you for review.

@mirielka mirielka added the ack Pull Request approved, can be merged label Nov 14, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants