Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the 1.4.x 389-DS Python installer #2312

Closed
wants to merge 10 commits into from

Conversation

Projects
None yet
8 participants
@tiran
Copy link
Member

commented Aug 31, 2018

Continuation and re-submit of #1563 to support DS python installer.

@stlaz

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2018

So the last thing that I did not have time to do is the verbosity of lib389. With the logs now being properly not-doubled, python-lib389 codebase still contains chunks of code doing

if self.verbose:
    self.log.info("neener-neener")

instead of setting up it's logger's logging level correctly, which results in lib389 being too verbose during the (un)installation (we set verbose=True to get the output).

You'll probably want to fix this to still get the log into the installer log-file while not having it printed on the output.

@tiran tiran force-pushed the tiran:new_ds_installer branch from dac5860 to 33fc974 Sep 6, 2018

@tiran tiran added needs review and removed WIP needs rebase labels Sep 6, 2018

@tiran tiran force-pushed the tiran:new_ds_installer branch from 33fc974 to 1d0be92 Sep 6, 2018

@Firstyear

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

I agree, I changed a lot to remove the "verbose" flag, we should just be using the log levels. Thanks for the reminder :)

@tiran

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2018

@Firstyear @stlaz Simon has opened a ticket for me, https://pagure.io/389-ds-base/issue/49938

@tiran tiran force-pushed the tiran:new_ds_installer branch from 1d0be92 to 11caf35 Sep 24, 2018

@tiran tiran removed the needs rebase label Sep 24, 2018

@tiran tiran force-pushed the tiran:new_ds_installer branch from 11caf35 to 084003f Sep 25, 2018

@tiran tiran added the re-run label Sep 25, 2018

@freeipa-pr-ci freeipa-pr-ci removed the re-run label Sep 25, 2018

@tiran tiran added the re-run label Sep 25, 2018

@freeipa-pr-ci freeipa-pr-ci removed the re-run label Sep 25, 2018

@tiran

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2018

test_service_permissions keeps failing with vagrant provisioning errors. Looks like a build host issue.

@Rezney

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2018

@tiran will try to take a look what is going on...

@tiran tiran force-pushed the tiran:new_ds_installer branch from 084003f to 9bd1ee1 Sep 27, 2018

@tiran tiran force-pushed the tiran:new_ds_installer branch from 9bd1ee1 to 3a83764 Oct 12, 2018

Firstyear and others added some commits Dec 1, 2017

DS uninstall: fix serverid missing in state restore
During uninstallation, we're using serverid which we get from
sysrestore.state. This was not set in the newer install,
return it back.
DS install: fix DS asking for NSS pin during install
DS now comes with nsslapd-security turned on and its own CA
cert in its NSS database. We're re-setting the NSS database
and setting our own CA cert to it, the DS pin file therefore
needs to be updated with the new password after this reset.
DS install: don't fail if SSL already configured
DS now comes with certain SSL capabilities turned on after
installation. Previously, we did not expect this and were
blindly forcing everything on without checking, whether it
needs turning on. This would result in failures if the
config entries are already set the way we want. Relax this
configuration.
Drop dependency on 389-ds-base-legacy-tools
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Remove DS perl paths from debian platform
Signed-off-by: Christian Heimes <cheimes@redhat.com>

@tiran tiran force-pushed the tiran:new_ds_installer branch from 788847f to 5911031 Nov 7, 2018

@abbra

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

ACK. Time has come to merge.

@abbra abbra added ack and removed needs review labels Nov 13, 2018

@tiran

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2018

master:

  • f7511ed Support the 1.4.x python installer tools in 389-ds
  • 8f9b0fc Remove some basic pystyle and pylint errors
  • 383311a Don't try legacy installs
  • ed955d1 Move lib389 imports to module scope
  • 56f8e20 DS uninstall: fix serverid missing in state restore
  • 104ef41 DS install: fix DS asking for NSS pin during install
  • e8342d4 DS install: don't fail if SSL already configured
  • 8fb6396 Use the newer way of removing the DS instance
  • a606b44 Drop dependency on 389-ds-base-legacy-tools
  • d39bb65 Remove DS perl paths from debian platform

@tiran tiran added the pushed label Nov 13, 2018

@tiran tiran closed this Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.