Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix webui tests #2324
Thanks for this PR. Looks as good addition. I did not test, so a temp commit which would run all web UI tests would be useful as already mentioned.
Added some comments - mostly ideas, not hard issues to change.
As @abbra mentioned, a ticket is needed as, I assume, this needs to be merged into 4-6 branch and we track backports in tickets.
Also, as good practice, it is good to mention in commit message "why" the change is needed (motivation), not only what is the change.
There are 4 fails. Two of them have timeout issues (test starts before user's logged in and so on). Other two are new tests, so I'll fix it in a separate branch, because this branch mostly for backporting.