ipatests: mark known failures as xfail #2437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 5dbcc1a marked the base class method test_replica0_with_ca_kra_dns_install as known failure, but this does not work with inherited classes. The child class methods need to be marked themselves as known failures with @pytest.mark.xfail Furthermore, TestInstallWithCA_KRA2 and TestInstallWithCA_KRA_DNS2 tests should succeed because the master is installed with KRA (issue 7651 is related to replica install with --setup-kra when it is the first KRA instance). Related to https://pagure.io/freeipa/issue/7651
|
Removed the temp commit. |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5dbcc1a marked the base class method
test_replica0_with_ca_kra_dns_installas known failure, but this does not work with inherited classes. The child class methods need to be markedthemselves as known failures with
@pytest.mark.xfail.Furthermore,
TestInstallWithCA_KRA2andTestInstallWithCA_KRA_DNS2tests should succeed because the master is installed with KRA (issue 7651 is related to replica install with --setup-krawhen it is the first KRA instance).
Related to https://pagure.io/freeipa/issue/7651