Add templating to ipaplatform path [RFC] #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ipaplatform.base.paths module contains a lot of repetitions. The path class now uses recursive format calls for common prefixes. The SO/SO_64 hack is replaced by platform detection. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
dry_ipaplatform_paths
branch
from
e64edd9
to
b53c1ad
Compare
MartinBasti
suggested changes
Nov 16, 2016
| @@ -184,21 +265,20 @@ class BasePathNamespace(object): | |||
| BIN_TIMEOUT = "/usr/bin/timeout" | |||
| UPDATE_CA_TRUST = "/usr/bin/update-ca-trust" | |||
| BIN_CURL = "/usr/bin/curl" | |||
| BIND_LDAP_SO = "/usr/lib/bind/ldap.so" | |||
| # BIND_LDAP_SO = "{.ARCH_LIB_DIR}/bind/ldap.so" | |||
There was a problem hiding this comment.
Why is this commented? If it is unused, it can be removed in separate patch
|
It has missing ticket |
|
It's a RFC patch. |
|
LGTM then, I'll wait for final version for testing |
|
Edit: wrong PR |
|
Can you finish this PR? It can be tested and possibly merged |
|
Also LGTM. |
|
Please ignore this PR for now. It's not relevant for PyPI packages. |
|
My PoC is a bit too magic and complicated. PR #373 for Debian support comes along nicely without additional magic. I'm closing the PR. I'll keep the branch around in case we want to tackle the problem in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please comment
The ipaplatform.base.paths module contains a lot of repetitions. The
path class now uses recursive format calls for common prefixes. The
SO/SO_64 hack is replaced by platform detection.
Signed-off-by: Christian Heimes cheimes@redhat.com