Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility with setuptools 0.9.8 #263

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 22, 2016

Setuptools 0.9.8 does not support PEP 440 version schema with +git
suffix.

Signed-off-by: Christian Heimes cheimes@redhat.com

@MartinBasti MartinBasti self-assigned this Nov 23, 2016
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Nov 24, 2016
@MartinBasti
Copy link
Contributor

Please add ticket to commit message

@tiran tiran removed the ack Pull Request approved, can be merged label Nov 24, 2016
@MartinBasti MartinBasti assigned pvomacka and unassigned MartinBasti Nov 24, 2016
@tiran
Copy link
Member Author

tiran commented Nov 28, 2016

PR #255 fixes the problem with download of wheel package.

@pvomacka
Copy link

I'm able to build FreeIPA on Fedora and it also fixes bugs in building on RHEL, so it works for me. But I don't see any ticket in the commit. Do we have any ticket for this?

@pvomacka pvomacka added the ack Pull Request approved, can be merged label Nov 30, 2016
@martbab
Copy link
Contributor

martbab commented Nov 30, 2016

Please reabse this PR and add ticket to the commit message.

Setuptools 0.9.8 does not support PEP 440 version schema with +git
suffix and PEP 508 env markers.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti closed this Dec 1, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Dec 1, 2016
@tiran tiran deleted the setuptools_compat branch December 1, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants