Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle service_del with bad service name #2640

Closed
wants to merge 1 commit into from

Conversation

@tiran
Copy link
Member

tiran commented Dec 4, 2018

The command 'ipa service-del badservice' used to fail with an internal
server error, because check_required_principal() could not handle a
principal that is not a service principal. All del commands have less
strict error checking of primary keys so they can reference any stored
key, even illegal ones.

check_required_principal() skips required principal check if the
principal is not a service principal. A non-service principal can never
be a required principal.

Fixes: https://pagure.io/freeipa/issue/7793
Signed-off-by: Christian Heimes cheimes@redhat.com

The command 'ipa service-del badservice' used to fail with an internal
server error, because check_required_principal() could not handle a
principal that is not a service principal. All del commands have less
strict error checking of primary keys so they can reference any stored
key, even illegal ones.

check_required_principal() skips required principal check if the
principal is not a service principal. A non-service principal can never
be a required principal.

Fixes: https://pagure.io/freeipa/issue/7793
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@abbra

This comment has been minimized.

Copy link
Contributor

abbra commented Dec 11, 2018

LGTM.

@abbra abbra added ack and removed needs review labels Dec 11, 2018
@tiran tiran added the pushed label Dec 11, 2018
@tiran

This comment has been minimized.

Copy link
Member Author

tiran commented Dec 11, 2018

master:

  • c09927d Handle service_del with bad service name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.