Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add main guards to a couple of Python scripts #265

Closed
wants to merge 1 commit into from
Closed

Add main guards to a couple of Python scripts #265

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 23, 2016 •
edited by MartinBasti

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran
Add main guards to a couple of Python scripts
6f4db82 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@MartinBasti MartinBasti self-assigned this Nov 24, 2016
@MartinBasti
Copy link
Contributor

Is this part of PIP effort? If yes then commit misses ticket

otherwise ACK

@tiran
Copy link
Member Author

tiran commented Nov 24, 2016

Not really. I had the patch around since 91920e7

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Nov 24, 2016
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a8376a244758494db31341442bc2163e1807b7ac

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Nov 24, 2016
@tiran tiran deleted the main_guards branch November 24, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@tiran @MartinBasti