Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: uniqueness of certificate renewal master #270

Closed
wants to merge 1 commit into from
Closed

Test: uniqueness of certificate renewal master #270

wants to merge 1 commit into from

Conversation

ofayans
Copy link
Contributor

@ofayans ofayans commented Nov 24, 2016 •
edited by martbab

martbab
martbab reviewed Nov 24, 2016
View reviewed changes
ipatests/test_integration/test_renewal_master.py
https://fedorahosted.org/freeipa/ticket/5902
"""
master = self.master
suffix = ",".join(["dc=%s" % i for i in master.domain.name.split('.')])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call ipa config-show and search for the value of IPA CA renewal master: to get renewal master name.

martbab
martbab reviewed Nov 24, 2016
View reviewed changes
ipatests/test_integration/test_renewal_master.py
result1 = self.replicas[0].run_command([
"ldapsearch", "-Y", "GSSAPI", "-b",
"cn=masters,cn=ipa,cn=etc,%s" % suffix,
"(ipaConfigString=caRenewalMaster)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here, you just assert that the value now equals to replica instead of master.

@martbab
Copy link
Contributor

martbab commented Nov 24, 2016

I have suggested some improvements in your code inline. Also, can we actually do this test as a part of other test suite or is it necessary to create a new one?

Also the commit message does not really state the purpose clearly.

@martbab martbab self-assigned this Nov 24, 2016
@flo-renaud
Copy link
Contributor

Hi,
you may also want to perform the same test after changing the renewal master with ipa config-mod --ca-renewal-master-server newrenewalmaster.example.com.

@martbab martbab added the ack Pull Request approved, can be merged label Dec 8, 2016
@martbab
Copy link
Contributor

martbab commented Dec 8, 2016

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/fad87a9962ee33cfebc4fa59aba589e98b076cea

@martbab martbab added the pushed Pull Request has already been pushed label Dec 8, 2016
@martbab martbab closed this Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martbab martbab martbab left review comments

Assignees

@martbab martbab

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@ofayans @martbab @flo-renaud