Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: URI records: bump python-dns requirements #277

Closed
wants to merge 1 commit into from
Closed

DNS: URI records: bump python-dns requirements #277

wants to merge 1 commit into from

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Nov 28, 2016

Support for DNS URI records has been added in python-dns 1.13

https://fedorahosted.org/freeipa/ticket/6344

@tiran
Copy link
Member

tiran commented Nov 28, 2016

You forgot to bump ipasetup.py.in.

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit pick :)

@@ -125,7 +125,7 @@ BuildRequires: python-lxml
# 5.0.0: QRCode.print_ascii
BuildRequires: python-qrcode-core >= 5.0.0
# 1.11.0: resolver.YXDOMAIN, Resolver.set_flags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see the comment before. Please update or remove the outdated comment.

Support for DNS URI records has been added in python-dns 1.13

https://fedorahosted.org/freeipa/ticket/6344
@MartinBasti
Copy link
Contributor Author

Thank you, fixed.

@tiran tiran added the ack Pull Request approved, can be merged label Nov 29, 2016
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Nov 29, 2016
@MartinBasti
Copy link
Contributor Author

@MartinBasti MartinBasti deleted the uri-bump branch November 29, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants