Added a sleep interval after domainlevel raise in tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe comment next to sleep why the sleep is there, may not hurt |
Due to race conditions the test sometimes catches 2 one-way segments instead of one bidirectional. We need to give the master time to merge the one-way segments before we test the output. https://fedorahosted.org/freeipa/ticket/6265
|
Done. |
| @@ -63,7 +64,9 @@ def test_backup_restore(self): | |||
| command = ["ipa", "topologysegment-find", DOMAIN_SUFFIX_NAME] | |||
| tasks.install_replica(self.master, self.replicas[0]) | |||
| backup_file = tasks.ipa_backup(self.master) | |||
| self.master.run_command(["ipa", "domainlevel-set", "1"]) | |||
| self.master.run_command(["ipa", "domainlevel-set", str(DOMAIN_LEVEL_1)]) | |||
There was a problem hiding this comment.
The last time I ACKed unrelated change in one commit
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to race conditions the test sometimes catches 2 one-way segments instead of
one bidirectional. We need to give the master time to merge the one-way
segments before we test the output.
https://fedorahosted.org/freeipa/ticket/6265