ipautil: check for open ports on all resolved IPs #284
Conversation
| if socket_type == socket.SOCK_DGRAM: | ||
| root_logger.debug(msg) | ||
| else: | ||
| root_logger.error(msg) | ||
| finally: | ||
| if s: | ||
| s.close() |
There was a problem hiding this comment.
The socket is not closed properly, I would say. s.close() is outside of the cycle but the cycle can open many sockets...
There was a problem hiding this comment.
The finally block is inside the cycle, so all opened sockets should be closed properly.
| # Do not log udp failures as errors (to be consistent with | ||
| # the rest of the code that checks for open ports) | ||
| if socket_type == socket.SOCK_DGRAM: | ||
| root_logger.debug(msg) |
There was a problem hiding this comment.
I would like to see this on WARNING level so it is consistent with messages printed by conncheck (and actually visible to user).
| # Do not log udp failures as errors (to be consistent with | ||
| # the rest of the code that checks for open ports) | ||
| if socket_type == socket.SOCK_DGRAM: | ||
| root_logger.warning(msg) |
There was a problem hiding this comment.
I just noticed that FreeIPA logging is so botched that it does not show WARNING messages by default. Please leave the code as it is and I will ack it.
|
needs rebase |
When a hostname is provided to host_port_open, it should check if ports are open for ALL IPs that are resolved from the hostname, instead of checking whether the port is reachable on at least one of the IPs. https://fedorahosted.org/freeipa/ticket/6522
|
Fixed upstream |
When a hostname is provided to host_port_open, it should check if
ports are open for ALL IPs that are resolved from the hostname, instead
of checking whether the port is reachable on at least one of the IPs.
https://fedorahosted.org/freeipa/ticket/6522