Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix miss translation in Chinese #286

Closed
wants to merge 1 commit into from

Conversation

shanyin
Copy link
Contributor

@shanyin shanyin commented Nov 30, 2016

Fix the missing translation in Chinese.

@shanyin shanyin mentioned this pull request Nov 30, 2016
@MartinBasti
Copy link
Contributor

We automatically add translations to IPA from zanata before releasing. If it is translated in zanata it will appear in next release.

@MartinBasti MartinBasti added the rejected Pull Request has been rejected label Nov 30, 2016
@shanyin
Copy link
Contributor Author

shanyin commented Nov 30, 2016

Ok, it was already translated in zanata. But what do you mean about you said "what I meant was to send fixing of missing translations strings as separated PR" in #174?

@MartinBasti
Copy link
Contributor

This:

-            label='Group search fields',
 +            label=_('Group search fields'),

@shanyin
Copy link
Contributor Author

shanyin commented Nov 30, 2016

Ok, I have just sent a PR.

@MartinBasti
Copy link
Contributor

Thanks

@shanyin shanyin deleted the fix-miss-translation branch December 1, 2016 11:25
@MartinBasti
Copy link
Contributor

@shanyin Your translations will be released in FreeIPA 4.4.3 soon

@shanyin
Copy link
Contributor Author

shanyin commented Dec 16, 2016

Ok, I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Pull Request has been rejected
Projects
None yet
2 participants