Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel bundles fixes #287

Closed
wants to merge 1 commit into from
Closed

Wheel bundles fixes #287

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 30, 2016

  • make wheel_bundle no longer bundles ipaplatform
  • ipaclient and ipalib use a consistent extra tag for the install
    subpackage. pip install ipalib[ipalib.install] looks a bit silly.

https://fedorahosted.org/freeipa/ticket/6474

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran
Copy link
Member Author

tiran commented Nov 30, 2016

Fixup for #271

@tkrizek tkrizek self-assigned this Nov 30, 2016
@tkrizek
Copy link
Contributor

tkrizek commented Nov 30, 2016

PR needs a rebase to fix extra_requires -> extras_require typo.

* make wheel_bundle no longer bundles ipaplatform
* ipaclient and ipalib use a consistent extra tag for the install
  subpackage. `pip install ipalib[ipalib.install]` looks a bit silly.

https://fedorahosted.org/freeipa/ticket/6474

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Nov 30, 2016

@tomaskrizek thanks! I rebased the PR.

@tkrizek
Copy link
Contributor

tkrizek commented Nov 30, 2016

I wasn't able to fully test this since there is an issue with building bdist_wheel. But since ipaplatform dependency has been removed, it seems to be all right.

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Nov 30, 2016
@MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Nov 30, 2016
@tiran tiran deleted the wheel_fix branch November 30, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants