Increase the timeout waiting for certificate issuance in installer #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcholast would it make sense to move this value into |
|
+1 |
|
@martbab @mbasti-rh: I checked the code and some parts already use api.env.startup_timeout for certmonger requests (in ipa_certupdate.py or ipa_cacert_manage.py for instance). Is it OK for you if I replace my hardcoded value with api.env.startup_timeout? |
|
IMHO anything is better than hardcoded values so you have my blessing. |
MartinBasti
suggested changes
Dec 6, 2016
| @@ -309,7 +310,8 @@ def request_and_wait_for_cert( | |||
| reqId = request_cert(nssdb, nickname, subject, principal, | |||
| passwd_fname, dns, ca, profile, | |||
| pre_command, post_command) | |||
| state = wait_for_request(reqId, timeout=60) | |||
| timeout = api.env.startup_timeout + 60 | |||
There was a problem hiding this comment.
I still see hardcoded value (60)
AFAIK startup_timeout is 5 minutes yb default, so there is no need for additional 60 seconds
During the server installation, the installer requests certificates through certmonger. The current timeout is 60s and is too low. Increase this timeout to api.env.startup_timeout as done in ipa_cacert_manage or ipa_certupdate.py (the code checks the status each 5s up to the timeout value). https://fedorahosted.org/freeipa/ticket/6433
MartinBasti
approved these changes
Dec 7, 2016
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the server installation, the installer requests certificates
through certmonger. The current timeout is 60s and is too low.
Increase this timeout to 120s (the code checks the status each 5s
up to the timeout value).
https://fedorahosted.org/freeipa/ticket/6433